Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
181 stars 70 forks source link

Escort initiative gets re-ordered by remote client #563

Open fonikz opened 6 months ago

fonikz commented 6 months ago

Describe the bug

Whenever a remote client performs an action, Escort with initiative 99 will be automatically pushed to the very front of the initiative stack.

Game Enviroment

Running ghs-server-v0.95.0.

I connect on same machine via Chromium browser with all permissions. Client 0.95.15.

Another player is connected via iPad running Safari, on local WiFi. Client 0.95.15. Permissions are {"characters":true,"character":[],"monsters":true,"monster":[],"scenario":false,"elements":true,"round":true,"level":false,"attackModifiers":false,"lootDeck":false,"party":true}

Running campaigns 19 and 27, escort is set up automatically.

To Reproduce

  1. Go to iPad client, connect in Safari
  2. Perform any action, i.e. add initiatives, modifying elements.
  3. See error: escort is thrust to the very top of the initiative stack (as if initiative 0, but visually still says 99) and will activate next when you tab through the current active character/monsters.

Expected behavior

Escort with initiative 99 should remain at the end of the initiative stack no matter

Gloomhaven Secretariat Version

v0.95.15

Used Browser

Safari (unsure version, latest assumed)

OS

iPadOS 17

Additional

No response

Lurkars commented 6 months ago

Thanks, I was already able to reproduce just by refreshing site. It was not related to server in any way, but the way the game state was stored (especially objectives...). Should be fixed now in v0.96.0. So happy if you can test again and close issue if solved.

Jaerin commented 6 months ago

This worked in our last scenario. The special we had no longer had its initiative updated from the starting value like it used too.