search

Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
180 stars 70 forks source link

Update ko translations #600

Closed derornos closed 3 months ago

derornos commented 4 months ago

Description

Update ko translations

Checklist:

Lurkars commented 4 months ago

I know it's easier to translate, if you have the English texts there to know what's missing. The issue is, that English is always fallback for missing label. If I now fix typos in English translations. The texts in KO will be wrong in first place and if you took this file to translate, you may also translate outdated/wrong labels. So I would suggest to remove all non-translated texts and try to work with an useful DIFF tool to see what's missing. (I may just implement a tool to show missing label?)

derornos commented 4 months ago

Thank you for your comments.

I'm adding English labels for the following reasons

  1. history management If some label updates are added and a long time passes, I may not notice and miss some of them. Often, when I compare the ko.json file with the en.json or de.json file after completing the translation, I find that the total number of lines is different because of the missing labels. As a result, I spend a lot of time trying to find the missing labels.
  2. Apply a quick update Often, updates to labels occur simultaneously across all json files under a locale. If that label doesn't exist in the ko.json file at that time, I can't figure out if the update has occurred or not.

Incidentally, the reason I don't use DIFF is that some ko.json files use labels that don't exist in the en.json file, but I'm constantly doing basic comparisons with the DIFF tool via VSCode to gain insights.

If you support scripts that can do the same thing, such as the file you can find in the link below, I might not mind the issues mentioned above. ex. update_locales