search

Lusito / dict.cc-translation

Firefox Addon for dict.cc
zlib License
37 stars 5 forks source link

New tab instead of micropanel is opened #39

Open Filbuntu opened 5 years ago

Filbuntu commented 5 years ago

When I click on translation from the right-click menu or on "more" from the overlayed translation windows, a new tab is opened instead of the micropanel. And even more annoyingly the new tab is opened in a new Firefox window! I guess it is a new behaviour of Firefox (65.0, Ubuntu Linux 18.04, but it has been a problem for many months and previous Firefox versions). I also checked in a clean Firefox profile. Is there chance that this could be fixed? I hope you still work on this great add-on, thanks in advance!

CennoxX commented 5 years ago

What are your add-on settings for the context menu and quick click? What is your expected behaviour? Also, I think you're confusing the the micropanel (the overlayed translation windows) with the pop up window.

Filbuntu commented 5 years ago

Thanks a lot for the quick response! Yes, you are right. I got confused with the names of the windows. Here is the micropanel, right? image I don't have a picture of a Popup as it does not work at the moment (neither pocket version nor with full details.) I have tried in Firefox with my usual profile (plenty of add-ons) and with a default profile without any other add-ons. In both profiles the Popup would be a new window with a dict-cc-tab, the supposedly pocket version seems to be smaller, though. My settings: screenshot from 2019-02-09 14-24-14 The expected behaviour: On clicking with Ctrl-key-press the micropanel opens and with clicking on "more", a Popup (overlayed window over the page, not an actual new Firefox window) would open. At least this was the behaviour I remember from the past. The micropanel opens fine, but the Popup is a new Firefox window with a dict-cc-tab. Hopefully I could explain it well.

Lusito commented 5 years ago

Your screenshot is the micropanel. "Popup (all details)" and "Popup (pocket version)" will open a new window.

In previous Firefox versions, before I ported this extension from firefox-sdk to web-extensions, it was possible to show an overlay without opening a tab or a window, but this is not possible anymore with web-extensions, which is why this is now shown as a new window or a tab instead.

To support the old style of overlay window, I would have to modify the website itself, which I'm already doing for the micropanel, but this approach is not without bugs and might not work as expected.

I've created a ticket on bugzilla to help bring this feature back, feel free to vote for this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1364404

Looking at this ticket being 2 years old already, however, I fear this is nothing Mozilla is keen on doing in the near future.

I've already supplied them a proposed API and a demo: http://lusito.info/panel-action/

Filbuntu commented 5 years ago

Thanks a lot for your detailed answer and clarification. Now I understand. It is a pity the situation is like this and I hope it will change. I will surely vote for the ticket.