Private Window support

[MarkNorden]

I've tried your extension for a bit and immediately noticed that when in a private window the extension is disabled. Is this a deliberate feature? If not; will support for private windows be added? Much appreciated!

[Lusito]

I disabled this on purpose, as otherwise (in it's current form) domains would be tracked for removal and the cookie log, which is not something you want/expect when browsing privately.

It would of course be possible to re-enable this, but it should be made with careful separation between private and non-private windows.

I've not considered this as a high priority issue, as private windows forget everything after close anyway. I am open about this tho, so please let me know your ideas on how you would expect the extension to work in private mode.

[MarkNorden]

Alright. After thinking about it some more I came to the conclusion that I don't know one thing: if I were to choose ''delete history', would it delete all of my history, or just the history of non-whitelisted sites from my current session? If it is the latter then my previous request is not neccesary and things are fine as is.

[Lusito]

Everything above the dashed line, which has an option "apply rules" will respect rules if you have that option checked. Everything else will be removed completely. However, it would be possible to apply the rules for the history API. Not sure about the "current session", as the history API only has the time of the last visit, so if you removed history entries from the current session, it would also remove items of the same url in history before this session.

And in your use-case, I guess you would want to forget the closed tab as well, as it could otherwise be restored (it's possible I think, tho the API is a bit confusing on this one, so I'll have to dig further into this).

Anyway, this would be a separate issue and if you want it, a new issue should be created with details of the request.

[Lusito]

Oh, btw. check out the clear recent history feature of firefox itself. It might be of interest to you.

[Joel889]

I don't know how much work this is, but couldn't the cookie log be disabled if in private mode?

[Lusito]

I swear, sometimes I don't get e-mails for comments.. @Joel889 what cookie log are you talking about? The cookie browser or the recently accessed domains? The latter should not be affected by private windows. The cookie browser lists cookies of private windows, but it's never stored anywhere. Should I remove private window cookies from the cookie browser list?

[cdober1950]

Would it be considered a bug if the "undo closed tab" function restores previously visited pages even after Forget-Me-Not has cleared history for those sites/pages? I seem to be able to do just this...

[verbzero]

I disabled this on purpose, as otherwise (in it's current form) domains would be tracked for removal and the cookie log, which is not something you want/expect when browsing privately.

Maybe better set a disclaimer about data tracking, not disabling it completely without an option? I'm asking cause in Tor Browser Bundle private mode is enabled by default, and deleting cookie\idb\ls\etc by custom rules would be very nice addition to all privacy-maintaining stuff already in use. In this usecase it's really synergistic, but now we have to choose between

• "delete all data on window close" (private mode)

• "delete some data by custom ruleset" (forgetmenot addon).

And I prefer private mode, cause it wipes all data, including cache\field values\history\service workers and so on. But I'd really liked use this addon too. Hope you'll reconsider such feature...