search

Lusito / forget-me-not

Make the browser forget website data, except for the data you want to keep.
zlib License
226 stars 25 forks source link

Addon is not cleaning localstorage #193

Open andreldmonteiro opened 4 years ago

andreldmonteiro commented 4 years ago

The addon is not cleaning localstorage upon closing tabs.

Speravir commented 4 years ago

I must confirm this. In addon settings I have the default clean on exit (or what the name in English is). But In the Firefox preferences I can see, that for quite a lot of pages the local storaged data has not been deleted, despite I have not whitelisted them. Unfortunately I was too fast with manual deleting there, but if I remember correctly the oldest data have been last used about two months ago, so this would would concur with the latest addon changes. I am not sure about this, though!

BTW see also in Vergiss Mein Nicht (cookies, local storage, etc. löschen) – Seite 3 pp. (at least until my reaction), though a bit confusing in linked posting.

Lusito commented 4 years ago

Please check out this explanation: https://github.com/Lusito/forget-me-not/issues/175#issuecomment-526918057

The essence of it: What firefox tells you is "Storage" is not just local-storage. It's indexed-db, local-storage, meta-data and maybe more. What remains after closing the tabs is meta-data, which can not be accessed by the website anymore. You can try it by checking http://lusito.info/storage/

Speravir commented 4 years ago

Thank you for information. I should have known this.

You can try it by checking http://lusito.info/storage/

For me it says 

Cookie:I don't remember you
Local Storage:I don't remember you
IndexedDB:I don't remember you

So it says it works as intended by me.

andreldmonteiro commented 4 years ago

I think you should let this bug open so that people see it.

andreldmonteiro commented 4 years ago

Something is not right, I get on first page of youtube, videos I watched before despite having closed all tabs and with 1 second delay delete settings, and these videos are not popular and are old to be on the first page and I'm not logged in nor do I have a google account nor do I have other pages open related to youtube or google. This clearly shows that the data firefox reports to still have that doesn't get cleaned is a problem.

andreldmonteiro commented 4 years ago

Can anyone test youtube?

andreldmonteiro commented 4 years ago

I have confirmed this, if I go to the firefox preferences and to cookies and site data and remove everything from youtube it stops displaying the videos!

So this is a bug!

Lusito commented 4 years ago

I just checked and can't reproduce.

Youtubes landing page shows me only video recommendations based on my previous videos as long as my cookies have not been cleaned. Once cleaning happened, everything gets reset back.

You can try this by using the manual cleanup and only select cookies. What might happen here is: If you have youtube open in one tab and another tab that has a youtube video embedded and you close youtube, then the embedded youtube video is still active, so it counts as youtube still being open.

Try these things to see if cleanup of cookies actually happened:

andreldmonteiro commented 4 years ago

The problem seems to be that I have a tab with a video of youtube, but that tab isn't loaded because I closed Firefox and opened it and it doesn't load the tab until clicking, is this a bug?

Lusito commented 4 years ago

Hard to say.. I have never tried a scenario like this. I would have thought, that tabs, which are not loaded, don't list their iframes. Will have to take a deeper look into this. Thanks for the extra information.

Sidenote: #83 and #54 cover the general questions of unloaded tabs.

rkuralev commented 4 years ago

I can confirm that the extension has issues with youtube. Neither cookies nor local storage are not cleaned on domain leave.

eadamy commented 4 years ago

I have a small whitelist and settings to delete cookies and local storage not whitelisted 10 seconds after leaving domain (attachment 1) The cookies are being cleaned properly. Local storage is not even after exiting FF and restarting. See highlighted items in attachment 2. 20200115 1030- 20200115 1033-Options

.

Lusito commented 4 years ago

beware of what firefox calls "storage" in the firefox options. This is not just local storage, but other storage as well (like indexed db, service workers and meta data).

Try this demo to see if your local storage gets deleted: http://lusito.info/storage/

eadamy commented 4 years ago

Thank you for the test which appears to show everything deleted for lusito.info. And thank you for the addon which does a great job with cookies.

I think the point that those of us writing about this are trying to make is that we don't care what FF calls it. Unless we flag it "Never", we want anything deposited by the website (including indexed db, service workers, and meta data) removed according to the timing of the rule. Just like the cookies.

Lusito commented 4 years ago

Yeah, I hear you. Sadly, there is little I can do at this moment.

eadamy commented 4 years ago

Hopefully, an issue you can address with version 3. Certainly understand not undertaking major improvements to the current version. Thanks again.