Lusito / webextension-polyfill-ts

This is a TypeScript ready "wrapper" for the WebExtension browser API Polyfill by Mozilla
zlib License
392 stars 23 forks source link

Missing members for `browser.webNavigation.onCommitted` details callback argument #80

Closed mnoorenberghe closed 1 year ago

mnoorenberghe commented 2 years ago

It's in the Firefox Schema and MDN but for some reason the type generation is missing a bunch of members, it only has the following:

    interface OnCommittedDetailsType {
        /**
         * The ID of the tab in which the navigation occurs.
         */
        tabId: number;

        url: string;

        /**
         * 0 indicates the navigation happens in the tab content window; a positive value indicates navigation in a subframe.
         * Frame IDs are unique within a tab.
         */
        frameId: number;

        /**
         * The time when the navigation was committed, in milliseconds since the epoch.
         */
        timeStamp: number;
    }
mnoorenberghe commented 2 years ago

Nevermind, I see now that it has "unsupported": true

mnoorenberghe commented 1 year ago

The incorrect unsupported:true were removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1837829

Lusito commented 1 year ago

@mnoorenberghe would you mind reviewing this PR? It helps speed up the release: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/65870

mnoorenberghe commented 1 year ago

Done. Looks like it's ready to merge