search

LuteOrg / lute-v3

LUTE = Learning Using Texts: learn languages through reading. Python/Flask.
MIT License
407 stars 45 forks source link

Various RTL errors #165

Open M-Biggles opened 7 months ago

M-Biggles commented 7 months ago

Several RTL bugs -- (moving to new issues if needed)

Remaining

C. (Reading page) Page changing bar at top should be RTL instead of LTR;

C

E. Numbers with , and . are ordered wrongly. BIDI issue?

Expected: 2

Current: 1

F. PDF import of RTL languages is broken

G. PDF export of RTL languages is broken

Fixed items

M-Biggles commented 7 months ago

Ok, I've never reported bugs before, so I'm hoping these are easy enough to understand and find.

jzohrab commented 7 months ago

Thank you very much! I had notes on these and was going to make an issue, so I appreciate you taking the time. I hope to address these soon-ish. Going by feel, they don't look like they'd have any blockers, except perhaps for the slider bar item C. I'll add this to the backlog close to the top, and as I start work on it I'll add notes here. Cheers!

M-Biggles commented 7 months ago

I found this resource and thought it might be a useful guide.

https://rtlstyling.com/posts/rtl-styling/

M-Biggles commented 7 months ago

@jzohrab

I've added a few more here (E, F + G) and will stuff keep adding more, but that's the most of it now. If we need to split any into separate issues, we can do so.

jzohrab commented 7 months ago

E is due to how Lute tokenizes the elements: in "1,900", "1" becomes a token, then ",", then "900", so those are output backwards. fyi only. :-) It's a tough problem.

F and G pdf stuff: PDF is brutal to work with. https://jzohrab.github.io/lute-manual/faq/books/pdf-import.html gives some brief notes about the problem. fyi only again.

M-Biggles commented 7 months ago

Understood, thanks for the further info! Focus on the easy ones and get to the tricky stuff on another day. :)

So, how are the texts tokenised? I'd like to explore it a little. Which files does Lute create and work with? Maybe I can think of something from a linguistics perspective.

jzohrab commented 7 months ago

Some of these are tougher than others, so I'll pull out smaller issues from the main as I can, and will reference this issue from them.