search

LuteOrg / lute-v3

LUTE = Learning Using Texts: learn languages through reading.
https://luteorg.github.io/lute-manual/
MIT License
493 stars 46 forks source link

Add text bookmarks #439

Closed cblanken closed 5 months ago

cblanken commented 5 months ago

This PR addresses issue #86 to add text bookmarks.

@jzohrab I'm pretty sure I've hit all the main requirements for the backend and smoke tests. Let me know if there's anything else I need to add or fixup before it would be ready to merge.

I think my next steps will probably be to add some demo data and maybe a mention of bookmarks in the Tutorial / Tutorial follow-up chapter and some basic acceptance tests.

I just wanted to get this PR posted before I lost steam :)

jzohrab commented 5 months ago

Thank you very much @cblanken ! I hope to start review today.

cblanken commented 5 months ago

Thanks for the review. I should have some time to fixup everything tomorrow 👍

cblanken commented 5 months ago

Oops. So it begins...me forgetting to run the lint before commiting now that the lint hook is disabled by default :disappointed:

jzohrab commented 5 months ago

Looks good! There are a few very small things (e.g. the bookmark title isn't required for a deletion, etc), but I'll fix them up when I check out this branch locally to try it out. I'll just commit those changes to my local branch, you'll see them when it's merged. I'll let you know if I get stuck, thanks very much @cblanken 👍

jzohrab commented 5 months ago

Launched in 3.5.0. :tada: