LuteOrg / lute-v3

LUTE = Learning Using Texts: learn languages through reading. Python/Flask.
MIT License
422 stars 46 forks source link

Term lists linked from the "term tags" page lists words without that tag - blocked by 429 #448

Open bwkimmel opened 3 months ago

bwkimmel commented 3 months ago

Description

If you click on the number from an entry in the "Term tags" page, this takes you to a list of terms supposedly having that tag. However, this list may include words that do not have that tag. In particular, it includes any words that have the text of that tag as a substring of any field.

Related: #429, though presumably this could be fixed without fully implementing what's suggested there.

To Reproduce

Steps to reproduce the behavior, e.g.:

  1. Create a word and tag it as, say, "verb"
  2. Create another word, and define it's translation to be, say, "proverb"
  3. Go to the term tags list, and find the row for the "verb" tag. It will correctly indicate that there is only 1 word with that tag (the word created in step 1)
  4. Click on the number in that row. The resulting list of words will include "proverb", even though it is not tagged as "verb".

Screenshots

image

Extra software info, if not already included in the Description:

jzohrab commented 3 months ago

Thanks @bwkimmel - this is the behaviour as currently designed (i.e., the search just does a big text search on several fields), but as you've noted, it's a bad design.

It is going to need #429 implemented, or something close to it, to solve this properly. I've never been bothered enough by it, but I agree it's not super great the way it is. Thanks for taking the time to create the issue. 👋