search

LuteOrg / lute-v3

LUTE = Learning Using Texts: learn languages through reading.
https://luteorg.github.io/lute-manual/
MIT License
493 stars 46 forks source link

Not possible to update unknown words using bulk import (without making them known) #465

Closed s-cork closed 3 months ago

s-cork commented 3 months ago

Description

It's currently not possible to update unknown words without unknown words becoming known words

To Reproduce

Create some unknown words as a csv upload the words using bulk import (create new terms, set new terms to unknown) observe you now have hover translations for these words and they remain unseen upload the words again using bulk import observe these unknown words now all have a status of 1

I was playing around with trying to bulk import an initial dictionary of terms for my target language. there was some trial and error as I improved the formatting or made mistakes But i couldn't update unknown words because in the code, uploading an existing word, if its status is 0 changes it to 1.

This was quite frustrating, particularly given i was importing hundreds of thousands of terms.

I think - if it's a bulk import, then the status should not change when updating unless the status is included in the csv.

jzohrab commented 3 months ago

Thank you, I agree it shouldn’t change it. Sorry about that! Should be a quick fix.

jzohrab commented 3 months ago

Thanks @s-cork , I changed this in develop, it makes more sense and the code is clearer too. Will be in the next launch, apologies for the hassle. Cheers!

jzohrab commented 3 months ago

Launched in 3.5.1.