Luthaf / rascaline

Computing representations for atomistic machine learning
https://luthaf.fr/rascaline/
BSD 3-Clause "New" or "Revised" License
44 stars 13 forks source link

Change the order of samples in spherical exansion by pair #151

Closed Luthaf closed 1 year ago

Luthaf commented 1 year ago

This is a follow-up to #147.

Previously, the samples would look like this

structure, pair_id, first_atom, second_atom
   0          1         1           0
   0          1         0           1
   0          2         1           2
   0          2         2           1
   1          1         1           0
   1          1         0           1
                ...
   0         -1         0           0
   0         -1         1           1
   0         -1         2           2
   1         -1         0           0
   1         -1         1           1

i.e; with the "self" pairs at the end of the samples, meaning there could be a jump in the "structure" sample. This changes it to group all structures, placing the "self" pairs first inside the samples for a given structure.

github-actions[bot] commented 1 year ago

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

github-actions[bot] commented 1 year ago

The documentation for this PR is (or will soon be) available on readthedocs: https://rascaline--151.org.readthedocs.build/en/151/

ceriottm commented 1 year ago

Works as advertised!