search

LuttyYang / luci-theme-material

this is a openwrt luci theme
331 stars 96 forks source link

Mouse-hover indicator for the horizontal menu causes flickering #12

Closed hnyman closed 8 years ago

hnyman commented 8 years ago

Looks like there is no space reserved for the mouse-hover indicator in the horizontal menu. That causes some vertical flickering when mouse moves to hover over an menu item. The page below moves a few pixels down when the indicator gets created and back up hwn mouse moves away. That looks like flickering :-(

The below image shows how the page contents have been pushed down by the indicator. The left side shows the normal placement and the right side shows the placement when indicator is visible. mousehover

LuttyYang commented 8 years ago

I fix it in version 0.2.5

hnyman commented 8 years ago

Thanks.

LuttyYang commented 8 years ago

not at all

hnyman commented 8 years ago

I installed manually your "0.25" to test it, but it would be good to import the changes to the sources in the Openwrt Luci repo, so that users will get the changes to their own personal builds and the changes are included in the daily buildbot snapshots. Hopefully you will create a pull request in the near future.

hnyman commented 8 years ago

@LuttyYang Could you please create a pull request to uplift the changes in 0.25 to the Openwrt Luci repository. Or should I cherrypick your changes to the repo?

LuttyYang commented 8 years ago

Sorry, over the past few days I am very busy

LuttyYang commented 8 years ago

After a few hours I would probably create a pull request

hnyman commented 8 years ago

Sounds good ;-)

LuttyYang commented 8 years ago

@hnyman I created a pull request.