LuttyYang / luci-theme-material

this is a openwrt luci theme
331 stars 96 forks source link

LED Configuration page delete buttons #26

Closed ghost closed 8 years ago

ghost commented 8 years ago

The delete buttons on the led configuration page appear orphaned from their respective rules due to the alternating background color applied.

Changing the selector .cbi-section-remove:nth-of-type(2n) to .cbi-section-remove:nth-of-type(2n+1) on line 676 in style.css seems to fix it.

LuttyYang commented 8 years ago

thanks

LuttyYang commented 8 years ago

Thank you for your feedback, but I did not find this problem on the my router (WNDR3800).

screenshot from 2016-03-30 12-22-16

ghost commented 8 years ago

This is what I see on my TP-Link Archer C7 running 15.05.1 with the theme installed from the 0.2.17 release ipk. It matches yours with the mentioned css change.

c7_led_config

ghost commented 8 years ago

To follow up, I no longer experience this issue after updating luci from git-16.081.39589-0207cb7-1 to git-16.164.65694-cd50f27-1 so it must have only occurred with older luci versions not in trunk.

There are other issues using a newer luci, such as the host column in wireless display having an unnecessary 200px max-width causing it to be off center as well as various margin and spacing errors especially on mobile, but otherwise the theme is very good.