Minor dropdown button issue on Spectacle

Luwx / Lightly

A modern style for qt applications.

Other

1.55k stars 104 forks source link

Minor dropdown button issue on Spectacle #164

Open AndhikaWB opened 2 years ago

AndhikaWB commented 2 years ago

Screenshot_20220331_120344

As you can see on the screenshot, the vertical line clip through the button and the down arrow has no right padding/margin. I'm using Manjaro default dark theme (Breath/Breeze).

xuzhao9 commented 2 years ago

Can you please try if https://github.com/Luwx/Lightly/pull/183 fixes your problem? Thanks!

luisbocanegra commented 2 years ago

Can you please try if #183 fixes your problem? Thanks!

This is how it looks for me with your patch

xuzhao9 commented 2 years ago

@luisbocanegra Hard to say if I should call it fixed or not... what do you think?

luisbocanegra commented 2 years ago

@xuzhao9 well it certainly looks better, tried myself changing the values a bit: changed https://github.com/xuzhao9/Lightly/blob/0f23211e19185ca68cdf8ab797b34bbb7be24e5b/kstyle/lightlystyle.cpp#L3804 to auto arrowRect(rect.adjusted(-2, 0, -3, 0)); (top yours, bottom mine) Is there any reference for how tall the vertical divider should look? I find it a bit too short

AndhikaWB commented 2 years ago

Sorry all for the late reply. I haven't tested it directly but seeing @luisbocanegra bottom (last) screenshot, it looks pretty good to me. The tallness is ok, but I think the left and right padding on the arrow could be increased slightly again? (like the original Breeze/the unfixed one).

As comparison here's how the original Breeze theme look.

Also notice the "export" button on your first screenshot, it looks like the (right) padding amongst the buttons is now a bit inconsistent (or maybe it's just my eyes). It's no big deal though, certainly better than the old one.