search

Luwx / Lightly

A modern style for qt applications.
Other
1.53k stars 101 forks source link

Toolbar opacity broken with glass color schema. #98

Open edpil02 opened 3 years ago

edpil02 commented 3 years ago

After reading your discussion : "You'll have to change the current color scheme (~/.local/share/color-schemes) for that , in the [Colors:Window] section, add a fourth value to BackgroundNormal, that is the transparency. I don't know if this will work if you are not running plasma, because Lightly, like breeze, still depends a lot on kde stuff."

I made a try with dolphin. All the window become blur except the toolbar which remains opaque.

edpil02 commented 3 years ago

There is a weird issue with alpha option in the color-schemes file: With alpha value in [Colors:Window] (BackgroundNormal) , menubar and toolbar don't follow titlebar color rule in contrary of what is explained in the Readme.md file.

Alpha value in [VW] (activeBackground) doesnt help but seems to reverse the titlebar color rule. Sorry for my english.

edpil02 commented 3 years ago

Get a good result after trying different alpha values.But a issue remains in the menubar ; only text regions are blurred.

Screenshot_20210407_085446

edpil02 commented 3 years ago

I solve the issue

i modify the line : painter->fillRect(rect, _helper->alphaColor(option->palette.color( QPalette::Window ), opacity/100.0) ); with painter->fillRect(rect, _helper->alphaColor(option->palette.color( QPalette::Window ), opacity) ); in bool Style::drawMenuBarEmptyAreaControl() fonction.

image

rayxxt commented 3 years ago

I solve the issue

i modify the line : painter->fillRect(rect, _helper->alphaColor(option->palette.color( QPalette::Window ), opacity/100.0) ); with painter->fillRect(rect, _helper->alphaColor(option->palette.color( QPalette::Window ), opacity) ); in bool Style::drawMenuBarEmptyAreaControl() fonction.

image

Can't find this line in lightlyblurhelper.cpp, What file is this line in?

edpil02 commented 3 years ago

/master/kstyle/lightlystyle.cpp line 4998

4996 // draw background 4997 int opacity = _helper->titleBarColor( true ).alphaF()*100.0; 4998 painter->fillRect(rect, _helper->alphaColor(option->palette.color( QPalette::Window ), opacity/100.0) );