Lux-AI-Challenge / Lux-Design-S1

Home to the design and engine of the @Lux-AI-Challenge Season 1, hosted on @kaggle
https://lux-ai.org/
Apache License 2.0
898 stars 151 forks source link

Starting lux-ai-2021 without parameters throws exception #112

Closed Gerenuk closed 3 years ago

Gerenuk commented 3 years ago

Starting lux-ai-2021 (version 2.1.0) without parameters throws an exception

> lux-ai-2021
node_modules/lib/node_modules/@lux-ai/2021-challenge/lib/es5/bin/runner.js:32
throw Error('Need two paths to agents');

A gentle error message would probably be better.

StoneT2000 commented 3 years ago

Wait actually, that's exactly the correct error message, you do need to provide two paths. Closing this

Gerenuk commented 3 years ago

It's indeed the correct message, but wouldn't it be cleaner to show an intended message? Relying on uncaught exceptions for output makes a dirty impression. I believe programmers might get more trust in the robustness, if there are no uncaught exceptions for simple reasons.