search

Lux-AI-Challenge / Lux-Viewer-S1

replay viewer
Apache License 2.0
34 stars 12 forks source link

Visualiser slows down significantly over time #4

Open lpkirwin opened 3 years ago

lpkirwin commented 3 years ago

To reproduce:

Every time you reset, the rendering slows down on the next run. For me, second replay is half the speed of the first, and it gets worse from there. You can fix it by refreshing the page or re-uploading the replay.

Two thoughts:

  1. As a quick fix, should be easy to just do a hard refresh when someone hits the reset button?
  2. I haven't looked at the code, and I'm not a JS dev, but to me this strongly suggests that there's some unnecessary data accumulating over time as successive frames are rendered (e.g. an array that always gets pushed to, never overridden or emptied). If that's true, then fixing the underlying problem should improve the performance of the visualiser quite a bit.
StoneT2000 commented 3 years ago

thanks for pointing this out! we'll look into this.