LuxArdens / Stellaris---RPG-Traits-mod

Stellaris mod: RPG Traits
MIT License
11 stars 9 forks source link

Events randomly not working #19

Closed LuxArdens closed 6 years ago

LuxArdens commented 6 years ago

As mentioned earlier, I can copy-paste working events, change only the id and they more often than not won't work at all. Either the game can't find them or the actual 'immediate' effects don't take place. Examples are the planet_regulation events, which do not work for me, but do for others. This slows down development significantly.

TvoEx commented 6 years ago

Some of the event tables in trait.txt are corrupt according to the eventmanager

TvoEx commented 6 years ago

[16:44:41][effect_impl.cpp:426]: destroy_colony effect at file: events/trait.txt line: 791 accepts only yes or no as values [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 795 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 795 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - id in events/trait.txtline: 796 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - hide_window in events/trait.txtline: 797 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_triggered_only in events/trait.txtline: 798 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - immediate in events/trait.txtline: 800 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - every_owned_planet in events/trait.txtline: 801 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - change_pc in events/trait.txtline: 802 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 821 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 824 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 824 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - id in events/trait.txtline: 825 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - hide_window in events/trait.txtline: 826 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_triggered_only in events/trait.txtline: 827 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - immediate in events/trait.txtline: 829 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - add_modifier in events/trait.txtline: 830 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - modifier in events/trait.txtline: 831 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - days in events/trait.txtline: 832 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 834 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 837 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 837 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - id in events/trait.txtline: 838 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - hide_window in events/trait.txtline: 839 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_triggered_only in events/trait.txtline: 840 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - immediate in events/trait.txtline: 842 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - every_country in events/trait.txtline: 843 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - limit in events/trait.txtline: 844 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - has_trait in events/trait.txtline: 845 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 847 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 852 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 859 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 859 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - id in events/trait.txtline: 860 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - hide_window in events/trait.txtline: 861 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_triggered_only in events/trait.txtline: 862 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - trigger in events/trait.txtline: 864 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 867 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 867 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - from in events/trait.txtline: 868 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - save_event_target_as in events/trait.txtline: 868 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 869 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 869 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - every_owned_leader in events/trait.txtline: 870 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - limit in events/trait.txtline: 871 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_same_species in events/trait.txtline: 871 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 872 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 872 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 874 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 874 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - limit in events/trait.txtline: 875 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_same_species in events/trait.txtline: 875 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 876 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 876 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 878 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 878 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - limit in events/trait.txtline: 879 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_same_species in events/trait.txtline: 879 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 880 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 880 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 882 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 882 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - limit in events/trait.txtline: 883 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_ship_class in events/trait.txtline: 884 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - is_same_species in events/trait.txtline: 885 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 887 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - = in events/trait.txtline: 887 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 889 [16:44:41][eventmanager.cpp:223]: Corrupt Event Table Entry - } in events/trait.txtline: 891

TvoEx commented 6 years ago

And the Horizon Signal event probably needs replacing as it doesn't work properly currently.

TvoEx commented 6 years ago

Fixed the corrupt event table by changing line destroy_colony = { keep_buildings = no } to destroy_colony = yes

Which revealed another error, a misplaced comma in the code.

TvoEx commented 6 years ago

Could that literally have been the thing breaking it?

LuxArdens commented 6 years ago

It was a tilde ` because of frequent console use during coding. removed them. Also, it turns out the game is really vague and fiddly about what is a valid event namespace and event id and what is not. I can't get a hold on what are the exact rules, but changing "planet_regulation" to "planreg" everywhere made things work properly again.