search

LuxCoreRender / LuxCore

LuxCore source repository
Apache License 2.0
1.14k stars 143 forks source link

Fireflies removing with Impulse Noise Reduction #475

Open Nicknroll opened 3 years ago

Nicknroll commented 3 years ago

I found that all denoisers are bad at dealing with fireflies, sometimes they make black holes around, which make them look even worse. RawTherapee is a great, open-source image editor which has a nice tool to remove fireflies called Impulse Noise Reduction. So i'm curious what if integrate this algorithm into denoiser pipeline, maybe it would give a more neat result?

Example 1: Screenshot from 2020-11-23 14-33-21 Screenshot from 2020-11-23 14-33-24 Example 2: Screenshot from 2020-11-23 14-34-37 Screenshot from 2020-11-23 14-34-39 Example 3: Screenshot from 2020-11-23 15-42-26 Screenshot from 2020-11-23 15-42-28 Example 4: Screenshot from 2020-11-23 14-35-44 Screenshot from 2020-11-23 14-35-45

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/94563247-fireflies-removing-with-impulse-noise-reduction?utm_campaign=plugin&utm_content=tracker%2F79505306&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F79505306&utm_medium=issues&utm_source=github).
juangea commented 3 years ago

Isn't that the same as clamping?

What is the difference between the Raw Therapy algo and clamping at render time?

Dade916 commented 3 years ago

Clamping at render time should work a lot better because it is done sample by sample while Raw Therapy can works only on the end result (the sum of all samples).

Nicknroll commented 3 years ago

Isn't that the same as clamping?

It was my first thought too But if clamp affect big bright areas, impulse denoise handle only pixels, both bright and dark.

Clamp with impulse denoise: test