LuxCoreRender / WindowsCompile

LuxCoreRender Windows Compilation Environment
11 stars 10 forks source link

Update to Boost 1.67.0 and OpenImageIO 1.8.11 #6

Closed acasta69 closed 6 years ago

acasta69 commented 6 years ago

Hello David,

I am creating pull requests for this deps update, however there is one problem I don't know how to solve, related probably with the new OIIO version. When SaveOutputs is used and then rendering is stopped, Luxcore hangs instead of exiting. It does not happen with with HDR formats, only with PNG, JPG, etc.

To reproduce with luxcoreui:

The same seems to happen with the pyluxcore_demo.py script available here: https://gist.github.com/Theverat/0707eb2bd4e99b66bc5777db2793ab67

Dade916 commented 6 years ago

It sounds like the new OpenImageIO leaves some thread hanging, I'm going to check.

Dade916 commented 6 years ago

It doesn't happen on Linux however I found this possible explanation: https://github.com/OpenImageIO/oiio/issues/1795

I applied a workaround, can you check if it works fine now ?

acasta69 commented 6 years ago

That was the cause. Actually it was failing only on Windows 7 (I have then checked on Win10 and it's ok). Your workaround is working fine on both systems.