Open lazarusA opened 3 months ago
I don't think this worked - I pushed a v0.0.16+docs1 tag and it built to the correct dir (see https://github.com/LuxDL/DocumenterVitepress.jl/commit/5c320b5e08199987659ea945bfe212c1fc475c87). Unfortunately the stable site is still not working.
To replicate, just push a new tag to the repo of the name v0.0.16+docs$i
.
do you see any hydration error
? anywhere? (is the same link, to the latest release? ) Also, I see that the diff in link you posted is kinda big.
This shows a hydration error as well...:(
yeah... here some related https://github.com/vuejs/vitepress/issues/3586 , but weird for us... why the ones that work, are actually working ?
I think the only common factor is the trustees in the sidebar...maybe removing those would help?
DimensionalData.jl doesn't have them.
more info, this is the corresponding warning:
The resource <URL> was preloaded using link preload but not used within a few seconds from the window’s load event. Please make sure it has an appropriate as value and it is preloaded intentionally.
definitely, is the re-direct load.
@asinghvi17 ok, could you test this one again, please? Also, could you please describe step by step how does this tagging works?
DP> git tag v0.0.16+docs$i # what's the $i for?
DP> git push v0.0.16+docs$I
is it like that? (from the current branch, la/hydration_error)
I mean the $i
in the Julia iteration sense, so docs1
, docs2
, docs3
- sorry for the confusion!
Yep that approach is pretty much correct except the push.
git tag v0.0.16+docs2
git push --tag
ok... thanks... I will try... after fixing the exclusion... as it is, the syntax is wrong 😄 .
I added DEBUG=true to the build CI just so we have more info, btw
yeah... it doesn't work. :( bad regex. I will leave it now. RIP 😢 .
All of them have this error in common. The favicon
path is not available for any site. Maybe not the issue, again. But another one 😞 .
Maybe for the favicon we have to modify the replacer, to push the correct path?
Here's the error I'm getting now - I also enabled debug logging. You can go straight to stable for this.
for me it looks like this. This is the first error, in the debugger mode.
and... that file, framework....
is really long for the packages failing.
For the ones working is really small:
my guess, is that we were using different versions of packages in the json config file.
Edit: nevermind... is not static... now I see the same pattern either way.
should we just use this solution? Not sure where exactly incorporate this into the current workflow.
https://github.com/LuxDL/Lux.jl/blob/daf571ac359fe602ba9ef773c444298c66bb1378/.github/workflows/DeployDocs.yml#L36-L39 @asinghvi17 ?
Huh, it looks like that fixes the Lux issue as well! ~Yeah if we can rewrite this in Julia that would be awesome to include. Then we only need the version selector to be "feature-complete" :D~
Edit: nevermind, that would only work at the doc deployment stage! Would have to add that as a hook to deploydocs
, which would be difficult in general usage (but would work for the DV docs).
if the solution proposed here works, then this should fix https://github.com/LuxDL/DocumenterVitepress.jl/issues/81