LuxDL / DocumenterVitepress.jl

Documentation with Documenter.jl and VitePress
https://luxdl.github.io/DocumenterVitepress.jl/
MIT License
63 stars 9 forks source link

La/hydration error #109

Open lazarusA opened 3 months ago

lazarusA commented 3 months ago

if the solution proposed here works, then this should fix https://github.com/LuxDL/DocumenterVitepress.jl/issues/81

asinghvi17 commented 3 months ago

I don't think this worked - I pushed a v0.0.16+docs1 tag and it built to the correct dir (see https://github.com/LuxDL/DocumenterVitepress.jl/commit/5c320b5e08199987659ea945bfe212c1fc475c87). Unfortunately the stable site is still not working.

To replicate, just push a new tag to the repo of the name v0.0.16+docs$i.

lazarusA commented 3 months ago

do you see any hydration error ? anywhere? (is the same link, to the latest release? ) Also, I see that the diff in link you posted is kinda big.

asinghvi17 commented 3 months ago
Screenshot 2024-04-03 at 1 28 19 PM

This shows a hydration error as well...:(

lazarusA commented 3 months ago

yeah... here some related https://github.com/vuejs/vitepress/issues/3586 , but weird for us... why the ones that work, are actually working ?

asinghvi17 commented 3 months ago

I think the only common factor is the trustees in the sidebar...maybe removing those would help?

lazarusA commented 3 months ago

DimensionalData.jl doesn't have them.

lazarusA commented 3 months ago

more info, this is the corresponding warning:

The resource <URL> was preloaded using link preload but not used within a few seconds from the window’s load event. Please make sure it has an appropriate as value and it is preloaded intentionally. definitely, is the re-direct load.

lazarusA commented 3 months ago

@asinghvi17 ok, could you test this one again, please? Also, could you please describe step by step how does this tagging works?

DP> git tag v0.0.16+docs$i # what's the $i for?
DP> git push v0.0.16+docs$I

is it like that? (from the current branch, la/hydration_error)

asinghvi17 commented 3 months ago

I mean the $i in the Julia iteration sense, so docs1, docs2, docs3 - sorry for the confusion!

Yep that approach is pretty much correct except the push.

git tag v0.0.16+docs2
git push --tag
lazarusA commented 3 months ago

ok... thanks... I will try... after fixing the exclusion... as it is, the syntax is wrong 😄 .

asinghvi17 commented 3 months ago

I added DEBUG=true to the build CI just so we have more info, btw

lazarusA commented 3 months ago

yeah... it doesn't work. :( bad regex. I will leave it now. RIP 😢 .

lazarusA commented 3 months ago
Screenshot 2024-04-04 at 14 42 40

All of them have this error in common. The favicon path is not available for any site. Maybe not the issue, again. But another one 😞 .

asinghvi17 commented 3 months ago

Maybe for the favicon we have to modify the replacer, to push the correct path?

asinghvi17 commented 3 months ago
Screenshot 2024-04-04 at 8 55 12 AM

Here's the error I'm getting now - I also enabled debug logging. You can go straight to stable for this.

lazarusA commented 3 months ago
Screenshot 2024-04-04 at 14 59 21

for me it looks like this. This is the first error, in the debugger mode.

lazarusA commented 3 months ago

and... that file, framework.... is really long for the packages failing.

For the ones working is really small:

Screenshot 2024-04-04 at 15 10 16

my guess, is that we were using different versions of packages in the json config file.

Edit: nevermind... is not static... now I see the same pattern either way.

lazarusA commented 1 month ago

should we just use this solution? Not sure where exactly incorporate this into the current workflow.

https://github.com/LuxDL/Lux.jl/blob/daf571ac359fe602ba9ef773c444298c66bb1378/.github/workflows/DeployDocs.yml#L36-L39 @asinghvi17 ?

asinghvi17 commented 1 month ago

Huh, it looks like that fixes the Lux issue as well! ~Yeah if we can rewrite this in Julia that would be awesome to include. Then we only need the version selector to be "feature-complete" :D~

Edit: nevermind, that would only work at the doc deployment stage! Would have to add that as a hook to deploydocs, which would be difficult in general usage (but would work for the DV docs).