search

LuxDL / DocumenterVitepress.jl

Documentation with Documenter.jl and VitePress
https://luxdl.github.io/DocumenterVitepress.jl/
MIT License
74 stars 11 forks source link

svg output is broken #41

Closed lazarusA closed 7 months ago

lazarusA commented 7 months ago

On master, the automatic output of images for the svg format is broken. Tested on https://github.com/lazarusA/TemplateDocsVitePress.jl

asinghvi17 commented 7 months ago

Should be fine after this release

lazarusA commented 7 months ago

Output is back but, now the svg doesn't re-scales to the div width. In mobile the figures overflow to the right. Also, the literate example works locally but no online, no figure 😢.

asinghvi17 commented 7 months ago

That is a problem. Should it be wrapped in an image tag?

lazarusA commented 7 months ago

yes. It should be wrapped with img tag. That's how is working now in BeautifulMakie. Well, how it was working with version 0 :D

asinghvi17 commented 7 months ago

I was trying to save as few files as possible :D

but it seems as though we can pass it as base64...I'll try to do that!