search

LuxDL / DocumenterVitepress.jl

Documentation with Documenter.jl and VitePress
https://luxdl.github.io/DocumenterVitepress.jl/
MIT License
63 stars 9 forks source link

The stable docs link in the README is broken #72

Open LilithHafner opened 3 months ago

LilithHafner commented 3 months ago

The readme link: https://luxdl.github.io/DocumenterVitepress.jl 301 Redirects to https://luxdl.github.io/DocumenterVitepress.jl/ which 200 redirects to https://luxdl.github.io/DocumenterVitepress.jl/stable/ which returns a webpage with status code 200, but this is the webpage:

Webpage showing 404 error

asinghvi17 commented 3 months ago

Yeah I think Vitepress is not happy with the symlink. Will investigate...

lazarusA commented 3 months ago

oh... this is bad. I didn't noticed this extra step. IMO, we shouldn't mess with it, all because we want back the old pattern. And if at all, it should be optional, moving forward we should have the cleanUrls as given by vitepress.

asinghvi17 commented 3 months ago

This is purely caused by deploydocs afaict

asinghvi17 commented 3 months ago

I guess we can provide a fixer function in deploydocs like so:

https://github.com/JuliaDocs/Documenter.jl/blob/a6f6c0c7e33f4b0c3fab38811ac691d646e2d46c/src/deploydocs.jl#L273-L276

which solves these problems? Not sure if that applies itself at the right time, though.