search

LuxDL / Lux.jl

Elegant & Performant Scientific Machine Learning in Julia
https://lux.csail.mit.edu/
MIT License
485 stars 58 forks source link

Restore the rrule for merge #659

Closed avik-pal closed 4 months ago

avik-pal commented 4 months ago

@chrisrackauckas this will fix the SciMLSensitivity error. Not sure what is the underlying issue though, this is clearly a type piracy which shouldn't be needed.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.87%. Comparing base (2a866be) to head (3d1e0c6).

Files Patch % Lines
src/chainrules.jl 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #659 +/- ## ======================================= Coverage 86.87% 86.87% ======================================= Files 50 50 Lines 2483 2491 +8 ======================================= + Hits 2157 2164 +7 - Misses 326 327 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 4 months ago

@oxinabox can we upstream this then?

oxinabox commented 4 months ago

Yes we can. I will move it, and add tests.