search

Luxocracy / NeatPlates

NeatPlates is a continuation of the original Tidy Plates in an attempt to keep it update date in the absence of its authors.
https://wow.curseforge.com/projects/neat-plates
80 stars 20 forks source link

Fresh DK #419

Closed vandiel01 closed 2 weeks ago

vandiel01 commented 4 months ago

Neatplates v441

Reproducable: Fresh DK Issue: Always give an error due to no spec selected (frost, unholy or blood) (didn't want to, needed to due to simple misc thing I need done)

Suggestion: Add Before line 81 in NeatPlatesWidgets\ResourceWidget.lua

'if GetSpecialization() == 5 then return end'

I did an /run print(GetSpecialization()) on a DK that hasn't picked a spec and shows me a '5'. This line above stop the error on any fresh DK

Luxocracy commented 4 months ago

I've fixed this in the latest version.

While just returning out of the power method technically stops the issue, it also stops the functionality of the widget. So I've made it default to blood runes if it cannot figure out what ones to use. Which is what happened here.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 90 days with no activity. If you feel the issue is still relevant, please leave a comment to prevent the issue from being closed in 30 days