Open paragkatoch opened 5 days ago
Currently, the data is indeed using the server time (UTC+8) based on the in-game announcements from SEA and their official website notices. But ideally, I'd want to make it much easier for the user to update the site data without having to do the conversions themselves.
To combat this in the meantime, I added a comment beside the type definition to use the server time, but there has to be a better way to do it.
export interface Event {
id?: number; // announcement id
name: string;
description?: string;
img: string;
startDate: string; // use Server time (UTC+8)
endDate: string; // use Server time (UTC+8)
color?: string; // defaults to automatically detecting the img color (prefer darker colors)
url?: string; // link to an informative page about the event
showOnHome?: boolean; // whether we show it in the home dashboard
}
Thanks for raising this issue!
Hiya @paragkatoch, the website has been updated to automatically detect the user's local time zone. It also has the options to pick which game server time you'd like to view as.
To keep it accurate, we still have to encode the data here as CST (UTC+8) YYYY-MM-DD HH:mm
strings. What do you think?
@Luzefiru The implementation is really good, but I think the conversion is not working as expected for events.
For featured banners
I think some events start globally at the same time and other start based on their regional time. Same can be said for end time as well. Need to monitor the start/end time for future events to verify this.
A flag might be needed if the above is true.
https://github.com/Luzefiru/wuwatracker/assets/61873006/b8407b6e-06a4-4b15-be40-74eb84f742f0
I think some events start globally at the same time and other start based on their regional time. Same can be said for end time as well. Need to monitor the start/end time for future events to verify this.
Yeah, this is the case for Genshin. I'm doing my best to look into a proper way to do this at the moment.
Alright, I think I was able to implement your suggestions, @paragkatoch. How does it look on your end?
@Luzefiru Time and timer is working perfectly for my region. But, if I switch to other region then they are wrong.
Like for Chicago its around 23:30 on 27th but it is showing 28th
Okay, I think I found the issue, can I reach you out via Discord? I'd appreciate it if you could make some time to test it out.
Sure, joined the discord channel
It seems to be perfect now, exactly when server resets at UTC+3
I assume there is no need in this list anymore?
Because its change ruining everything
Because its change ruining everything
The next update to the site should fix this. Please let me know if you're having any issues despite that, @antisocial93.
Because its change ruining everything The next update to the site should fix this. Please let me know if you're having any issues despite that, @antisocial93.
There is one, btw
The hazard zone, which info about i'd commited today to events.ts stopped showing itself in the timeline
edit: i see, it's because there is no space for it rn?
Problem
The time in Timeline is without timezone. Thus leading to confusion.
Possible Solution
Really like the idea of crowdsourcing the event updates, but we can add a rule to it that the time should be in server time i.e., UTC+8 and then we can convert it to the user's timezone on client side.