search

Luzefiru / wuwatracker

wuwatracker.com - A Collection of Wuthering Waves Tools; Pity Tracker, Game Calendar, Data Exporter, and more!
https://wuwatracker.com
62 stars 18 forks source link

Update events.ts #69

Closed PyrZern closed 3 days ago

PyrZern commented 5 days ago

Testing timeline events for Tower of Adversity and the Illusive Realm. Actual time might not be accurate :/

Problem Context

Explain the details for making this change. What existing problem does the pull request solve?

Solution

Please provide enough information so that others can review your pull request:

Testing

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Closing Issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

antisocial93 commented 3 days ago

i suppose there is no need in this pr anymore due to done commits? although making the ToA a recurring event is a good idea, its timer set on 2 weeks, as far as i know, what do you think, @Luzefiru?

Luzefiru commented 3 days ago

i suppose there is no need in this pr anymore due to done commits? although making the ToA a recurring event is a good idea, its timer set on 2 weeks, as far as i know, what do you think, @Luzefiru?

Right, we've updated it already. I'll need to change the implementation a bit to keep recurring events like ToA in the same row in the timeline. I'll be closing this PR now. Thanks @PyrZern & @antisocial93!