search

Luzifer / nginx-sso

SSO authentication provider for the auth_request nginx module
Apache License 2.0
282 stars 41 forks source link

change Bootstrap theme via config #80

Open Bergruebe opened 1 year ago

Bergruebe commented 1 year ago

Hey, it would be great if the Bootstrap theme would be configurable in the config file. I am a dark mode fan, so I change the theme after every update to a dark theme manually, because my changes in index.html are overwritten.

So it would be really great if thees lines would be accessible over the config file: https://github.com/Luzifer/nginx-sso/blob/58021f2cfe0727d3d6f923be2cd20b632700e2c9/frontend/index.html#L10-L12

as an optional argument. In this way it would be also possible to self host the theme so you don't depend on jsdelivr for the login page. (I needed some time to find out, that I blocked jsdelivr in PiHole by mistake.)

Thank you very much for your work and this great pice of software, which protect my personal web apps. Danke!

Luzifer commented 1 year ago

Please have a look at the v0.27.1 - That one should no longer overwrite your themeā€¦ šŸ¤” (There was a bug in the startup-script fixed in the v0.27.1ā€¦)

In general: Yipp, I'm planning for a rewrite of some parts and there will be no more dependencies to externally hosted componentsā€¦ Keeping this as a reminder for myself to make the theme more configurable.

Bergruebe commented 1 year ago

Thank you for your answer. I usually don't visit the login page, so I don't really know, when the file was changed. But it is good to hear, that the problem was fixed.

I'm looking forward to the coming development!