Luzifer / ots

One-Time-Secret sharing platform with a symmetric 256bit AES encryption in the browser
https://ots.fyi
Apache License 2.0
470 stars 69 forks source link

Feature request: passphrase protection of a secret #169

Closed mshedsilegx closed 9 months ago

mshedsilegx commented 9 months ago

I would be a welcome addition for the secret sender to be able to passphrase protect a secret. Similar to the below: image

For the recipient, the secret could not be access without entering the correct passphrase: image

I think that provides another layer of protection that is useful in several test cases.

Luzifer commented 9 months ago

Please go into more detail how this increases security over the current measures:

So what's the benefit of placing a plain text password on the already strongly encrypted secret?

mshedsilegx commented 9 months ago

That would add an additional protection if the OTS link has been forwarded incorrectly or compromised

Luzifer commented 9 months ago

TBH: 99.99% of the users will either omit this or send the password the same way the link was sent. Most likely in the same message. Is the complexity really worth it?

Also the example screenhots you provided: They are sending the secret and the password in plain text to the server and are calling that "secure" and "secret"… They are not a reference.

So how would this work? The secret is encrypted with a random password and sent to the server as currently. What's happening to the password?

I'm not convinced this is a useful addition. It makes stuff a lot more complex, in certain ways of implementing it, it will expose information which shouldn't be there. In other ways it violates the "zero knowledge" principle in the backend by making i.e. the password known to the backend.

mshedsilegx commented 9 months ago

OK, let's close this