search

Lvl4Sword / Killer

🔪 System tamper detector for USB, Bluetooth, AC, Battery, Disk Tray, and Ethernet.
https://pypi.org/project/killer/
GNU Affero General Public License v3.0
71 stars 11 forks source link

Incorrect Config Parsing #23

Closed MarkKoz closed 5 years ago

MarkKoz commented 5 years ago

Lists are not parsed properly. There is no concept of a list in configparser. The canonical way of having lists is to delimit the elements and then split the string by the delimiter when parsing.

Also, the default config is missing some keys for windows. Namely USB_ID_WHITELIST and USB_CONNECTED_WHITELIST.

Lvl4Sword commented 5 years ago

Do you want to work on this?

MarkKoz commented 5 years ago

I didn't realise this is Windows only. A quick fix would be to just load it as json as is done for POSIX. I may fix this later but I'm busy with logging right now.