LxMLS / lxmls-guide

Lisbon Machine Learning Summer School Lab Guide
81 stars 61 forks source link

for loop missing in the backward algorithm #70

Closed davidbp closed 9 years ago

davidbp commented 9 years ago

In the current version of the pseudocode of backward algorithm we have screen shot 2015-06-12 at 20 21 31

where c_l is not specified. Should it be something like this?

screen shot 2015-06-12 at 20 24 18

This is relevant. I have create an issue in the lxmls_toolkit since:

Maybe this detail about the logsum is already correct. I am sure anyway that the loop over the different states is needed.

ramon-astudillo commented 9 years ago

The code is right. Have a look at Eq 25 in http://www.gao.ece.ufl.edu/eel6825/rabiner_hmm.pdf

for a more general view on why this is like this see

http://www.stat.columbia.edu/~liam/teaching/neurostat-fall14/papers/hmm/minka-lds-techreport.pdf

davidbp commented 9 years ago

THe code might be right but what about the pseudocode of the algorithm? In the code there is a double for in both the forward and the backward algorithms but the pseudocode given just has a for in the backward algorithm.

ramon-astudillo commented 9 years ago

Ok, that part seems to be wrong, yes. So the parenthesis are ok, but there is indeed a missing for. Could you please ad it?.

davidbp commented 9 years ago

Corrected with pull request