Wrong solution in sequence models' notebook exercise 2.10

LxMLS / lxmls-toolkit

Machine Learning applied to Natural Language Processing Toolkit used in the Lisbon Machine Learning Summer School

Other

223 stars 215 forks source link

Closed JoaoLages closed 6 years ago

JoaoLages commented 6 years ago

In labs/notebooks/sequence_models/Exercises_2.1_to_2.11.ipynb the solution to the exercise 2.10 shows the function train_EM when the objective was to construct the update_countsfunction instead.

JoaoLages commented 6 years ago

The headline of Exercise 2.11 should be change to 'Run 20 epochs of the EM algorithm for part of speech induction.' also.

ramon-astudillo commented 6 years ago

Thanks @JoaoLages can you make a PR with these changes to develop?

JoaoLages commented 6 years ago

Sure. Should only be this #106