search

LxMLS / lxmls-toolkit

Machine Learning applied to Natural Language Processing Toolkit used in the Lisbon Machine Learning Summer School
Other
222 stars 216 forks source link

Fix parameter name and variable cast #136

Closed pschydlo closed 5 years ago

pschydlo commented 5 years ago

1) Fixes typo in parameter name from "linput" to "input" which seems to be the intended name 2) Can anyone confirm that the variable cast does not have any unintended repercussions in the rest of the code base? The loss function seems to expect a long type while the conversion was to float.

ramon-astudillo commented 5 years ago

Thanks @pschydlo the ImportError: No module named categorical error seems to persist in Travis, see above.

https://travis-ci.org/LxMLS/lxmls-toolkit/builds/544238058?utm_source=github_status&utm_medium=notification

Do you get this error locally?

pschydlo commented 5 years ago

Locally all the test run well!

I have been trying to understand this issue today but haven't made much progress, I'll try to look at it again tomorrow!

Something I do differently locally is run pytest with "python -m pytest" to force it to use the pytest in the current environment instead of the system one, but this doesn't seem to be the issue here I think.

ramon-astudillo commented 5 years ago

From the error it seems not to recognize the torch namespace. Maybe it has to do with the installation.

On Tue, Jun 11, 2019, 7:20 PM Paul Schydlo notifications@github.com wrote:

Locally all the test run well!

I have been trying to understand this issue today but haven't made much progress, I'll try to look at it again tomorrow!

Something I do differently locally is run pytest with "python -m pytest" to force it to use the pytest in the current environment instead of the system one, but this doesn't seem to be the issue here I think.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/LxMLS/lxmls-toolkit/pull/136?email_source=notifications&email_token=AAK3OCIWJDYHC6QQXH4UMCTP2AXK5A5CNFSM4HW6QTVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXOY75Y#issuecomment-501059575, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK3OCJFFMOHBPNCLKV76M3P2AXK5ANCNFSM4HW6QTVA .