search

LxMLS / lxmls-toolkit

Machine Learning applied to Natural Language Processing Toolkit used in the Lisbon Machine Learning Summer School
Other
222 stars 216 forks source link

code cleanup for RL day #162

Closed zmarinho closed 2 months ago

zmarinho commented 5 years ago

remove deprecated code and add solutions and exercises for day 6 into a single file.

ramon-astudillo commented 5 years ago

@LxMLS/monitors2019 I would like to be sure that you are ok with this changes before accepting

antoniogois commented 5 years ago

I left a couple comments here

antoniogois commented 5 years ago

summary of the comments:

1) It seems that now it's clear which bit the students have to complete in 6.5, but I think the students' branch still won't have the incomplete version, after the PR is accepted.

2) I think the mismatch between the pdf (which seems correct) and notebook (which seems wrong) for 6.5 hasn't been addressed yet