Open ramon-astudillo opened 1 year ago
Ensure guide and code match for the RNN exercise. Also add possible improvements for readability and easy comparison between Numpy and Pytorch versions
this affects the file from the guide
https://github.com/LxMLS/lxmls-guide/blob/master/pages/deep_learning/deep_learning_rnn.tex#L75
and could affect followinglxmls-toolkit files
lxmls-toolkit
labs/notebooks/non_linear_sequence_classifiers/exercise_1.ipynb labs/notebooks/non_linear_sequence_classifiers/exercise_2.ipynb https://github.com/LxMLS/lxmls-toolkit/blob/master/lxmls/deep_learning/numpy_models/rnn.py
and student branch versions thereof.
student
equivalent guide issue https://github.com/LxMLS/lxmls-guide/issues/148
So I am confused. I checked the guide and rnn code and it matches. Whats the issue? What am I miss understanding?
Best, Gonçalo
Ensure guide and code match for the RNN exercise. Also add possible improvements for readability and easy comparison between Numpy and Pytorch versions
this affects the file from the guide
https://github.com/LxMLS/lxmls-guide/blob/master/pages/deep_learning/deep_learning_rnn.tex#L75
and could affect following
lxmls-toolkit
fileslabs/notebooks/non_linear_sequence_classifiers/exercise_1.ipynb labs/notebooks/non_linear_sequence_classifiers/exercise_2.ipynb https://github.com/LxMLS/lxmls-toolkit/blob/master/lxmls/deep_learning/numpy_models/rnn.py
and
student
branch versions thereof.equivalent guide issue https://github.com/LxMLS/lxmls-guide/issues/148