search

Lxtharia / minegrub-theme

A Grub Theme in the style of Minecraft!
MIT License
3.22k stars 41 forks source link

Use splash hash rather than index for caching #24

Closed saroh closed 12 months ago

saroh commented 1 year ago

This allows to add/ remove splash texts while not "corrupting" the cache.

This has been tested on Arch which is the distro I use, BTW!

Patish11 commented 1 year ago

This allows to add/ remove splash texts while not "corrupting" the cache.

This has been tested on Arch which is the distro I use, BTW!

Lxtharia commented 1 year ago

Hi! Nice idea with hashing the texts! Sadly, the hash function seems to not really hash consistently, which kinda makes the cache not a cache anymore x>

image

Is this only a problem on my machine?

Samsu-F commented 1 year ago

the problem is the use of the hash() function. It returns the hash of objects, so every time you execute the program, a new object will be created (even for an identical string) and therefore the hash of the different object will also be different

Lxtharia commented 12 months ago

Fixed with #30