search

Lxtharia / minegrub-theme

A Grub Theme in the style of Minecraft!
MIT License
3.22k stars 41 forks source link

create `backgrounds/` directory in `update_theme.py` if dir does not exist #40

Closed Samsu-F closed 11 months ago

Samsu-F commented 11 months ago

fixes #39 This is a problem I have overlooked, sorry

I think having an empty directory there in the repo would be better, but afaik this is not possible with git

Samsu-F commented 11 months ago

A different way to fix this would be to include a dummy file in minegrub/backgrounds/ (file name starting with an underscore!) to be able to add this directory to the repo. I am honestly not sure which of the two is the better solution

Samsu-F commented 11 months ago

I thought about it a bit more and I think the best solution is the following: Change update_theme.py to ignore files that start with a dot (choosing the underscore was a stupid decision of me anyway). Then add the backgrounds directory with a hidden dummy file in it.

I can implement this later today Edit: see #41

Lxtharia commented 11 months ago

Fixed by #41