Lxtharia / minegrub-theme

A Grub Theme in the style of Minecraft!
MIT License
3.22k stars 41 forks source link

Shadows for text #9

Closed OleSTEEP closed 1 year ago

OleSTEEP commented 1 year ago

Hello, when I first saw this theme for GRUB, I was confused by the fact that the labels on the buttons look somehow wrong. I compared them with what I see in the game and realized what the problem is - the lack of shadows for the letters! It seems to me that adding shadows would have a positive effect on the visual part of this theme in the future. Perhaps you will find my attempt to add shadows to letters for this theme useful (There is a text alignment problem and in general I don’t quite like my implementation).

preview_minegrub

Lxtharia commented 1 year ago

Looked through your theme.txt, does this actually work?? i didn't realize you could draw the boot menu items more than once. I haven't tested it yet, so i don't know what you mean with "text aligment problem". But thank you a lot! I will look into it, shadows would improve it a lot i think!

OleSTEEP commented 1 year ago

"Text alignment problem" (Text not in center):

image

Lxtharia commented 1 year ago

Ohh, i see. The text always get placed in the middle of the field, so I will have to adjust the pixmaps a bit!

Lxtharia commented 1 year ago

Done! Thanks you, the whole theme looks a lot better now! :D