Comments - Githubissues

Ly-Olia / WeatherApp

0 stars 0 forks source link

Comments #3

Open Greeengooo opened 1 month ago

Greeengooo commented 1 month ago

Great work! ❤️

Greeengooo commented 1 month ago

Add Readme for the repository. You should cover:

Short description of the project and what application does in 2-3 sentences
List the components of the application: weather collection, authentication, notifications, etc
Briefly describe each of them and show API specification for the most importatn endpoints. You can copy it from the localhost:8080/docs
List the tech stack. language, database, some libraries like asyncio, bcrypt, pydantic and apscheduler

Greeengooo commented 1 month ago

What is the purpose of the README in alembic directory?

Greeengooo commented 1 month ago

While pass is absoluterly valid approach, for better readability you can also use ... https://github.com/Ly-Olia/WeatherApp/blob/2cba11d1418905270cca649282e451f208273c43/app/schemas.py#L56-L57

So it will look like this:

class SomeClass:
    ...

Greeengooo commented 1 month ago

Why from_attributes = True is needed here? https://github.com/Ly-Olia/WeatherApp/blob/2cba11d1418905270cca649282e451f208273c43/app/schemas.py#L24-L25

Greeengooo commented 1 month ago

crud file refers to CreateReadUpdateDelete that is basically all operations performed over the storage. I would move all the functions that are making external requests to the API to a separate file. Also functions that are not related t database or API can be moved to a file called utils.py. https://github.com/Ly-Olia/WeatherApp/blob/2cba11d1418905270cca649282e451f208273c43/app/crud.py#L1