search

Lyall / FFXVIFix

A fix for Final Fantasy XVI that adds ultrawide/narrower support, uncaps framerate in cutscenes, lets you adjust gameplay FOV and much more.
MIT License
228 stars 8 forks source link

Framegen disables itself on cutscenes. #4

Closed Toru77 closed 3 weeks ago

Toru77 commented 3 weeks ago

Cutscenes disable framegen which causes smoothness difference between gameplay and cutscenes.

Lyall commented 3 weeks ago

Are you positive that framegen is being disabled? I just did a quick test with the intro cutscene and the framerate takes a big leap with framegen on. I believe what you are seeing is the more demanding nature of the cutscenes. I'm fairly sure they are engaging a much higher quality depth of field and likely some other graphical improvements. They are very heavy even on something as high-end as a 4090.

Framegen off: ffxvi_demo_2024_08_22_20_12_44_346

Framegen on: ffxvi_demo_2024_08_22_20_13_26_019

Lyall commented 3 weeks ago

Actually, disregard my previous post. Frame generation (at least DLSS frame gen) is disabled during certain cutscenes. Using SpecialK, I enabled the DLSS-G indicator and checked before and after entering a cutscene.

Before: fg on gameplay

After: frame gen cutsecne

TryHard-twt commented 3 weeks ago

I was going to test this mod when I get home, but is there still a problem with Framegen during cutscenes when using the mod? Do we all use Special K to fix it?

Lyall commented 3 weeks ago

I was going to test this mod when I get home, but is there still a problem with Framegen during cutscenes when using the mod? Do we all use Special K to fix it?

I think you might be misunderstanding, I'm only mentioning SpecialK as it will let you enable an indicator that shows when DLSS Frame Generation is active. That's how I can tell for sure it's turning off in certain cutscenes.

TryHard-twt commented 3 weeks ago

I was going to test this mod when I get home, but is there still a problem with Framegen during cutscenes when using the mod? Do we all use Special K to fix it?

I think you might be misunderstanding, I'm only mentioning SpecialK as it will let you enable an indicator that shows when DLSS Frame Generation is active. That's how I can tell for sure it's turning off in certain cutscenes.

Ah, okay. Yes, I misunderstood. As for the mod itself, I'm only 20min in but it's working perfectly. :) Edit: So I guess it is turning off Frame Generation in cutscenes, but it's still a lot better than being locked at 30fps.

Lyall commented 3 weeks ago

ffxvi_demo_2024_08_23_12_47_22_425

Alright, looks like I've found a way to leave frame generation on in cutscenes. Will need to do a bit more testing then hopefully I can implement it.

Lyall commented 3 weeks ago

Here is a test build with the option to force frame gen on all the time. Check FFXVIFix.ini to enable it and let me know if you run into any issues.

FFXVIFix_v0.7.2_test2.zip

TryHard-twt commented 3 weeks ago

Here is a test build with the option to force frame gen on all the time. Check FFXVIFix.ini to enable it and let me know if you run into any issues.

FFXVIFix_v0.7.2_test2.zip

Much appreciated. 👍 I'll have to check it later on today but I'll see if it works as soon as possible.

Karf commented 3 weeks ago

This appears to be working for me, even for FMVs. It's trying to frame gen those, and it's producing something that looks like 35-42fps with some inconsistent frame rate/times, but that's fine. Nothings perfect, this is mod. For some reason, it's taking 95-99% of my 4090 to do it, but again, who cares. It's the game's code doing something weird there. If I limit the game to 30fps with framegen on, the FMV takes 45% of the GPU.

Lyall commented 3 weeks ago

This appears to be working for me, even for FMVs. It's trying to frame gen those, and it's producing something that looks like 35-42fps with some inconsistent frame rate/times, but that's fine. Nothings perfect, this is mod. For some reason, it's taking 95-99% of my 4090 to do it, but again, who cares. It's the game's code doing something weird there. If I limit the game to 30fps with framegen on, the FMV takes 45% of the GPU.

This fits pretty much with what I was getting on my end too. Ideally it would maintain behaviour from the standard game. It turns off frame gen in cutscenes, pre-rendered videos and menus. I already have a hook for resizing videos so I can tell when one is playing. That would at least solve frame generation being on during video sequences.

Lyall commented 3 weeks ago

Alright, looking deeper I was able to find the function specifically responsible for turning off frame-gen in real time cutscenes. Here is another test build with that implemented.

FFXVIFix_v0.7.2_test3.zip

TryHard-twt commented 3 weeks ago

Just came here to say it seems to be working perfectly now. Cutscenes on my end are just as smooth as the gameplay. 👍

Karf commented 3 weeks ago

Yeah, I can also confirm that v0.7.2_test3 is working perfectly. Framegen is no longer trying to muck up FMVs and is working during rendered cutscenes 👍

Lyall commented 3 weeks ago

Added in v0.7.2