Lyall / MetaphorFix

A fix for Metaphor: ReFantazio that adds ultrawide/narrower support and much more.
MIT License
330 stars 5 forks source link

Custom shadow resolution broken on game 1.04 + fix 0.8.3 #103

Open ipisano opened 1 week ago

ipisano commented 1 week ago

As title, the setting appears to be completely ignored. Too lazy to provide screenshots, but I'm 100% sure the issue is there, as the difference from stock and increased shadow resolution is extremely noticeable on my 4K display. Rolling back to 0.8.2 fixed the issue. Of course, I have two separate ini files because the config names/parameters have been changed.

Unrelated, but I also either don't understand the camera sway option or that doesn't work either. I never tested it on 1.03 or before, but on 1.04 the option doesn't seem to work either on fix 0.8.2 or 0.8.3, but there's an option in the game's setting that apparently removes that sway? It does help a lot with the perceived amount of aliasing.

If that matters, I'm playing the MS Store / Xbox / UWP / WinGDK version.

Edit: I'm using the "regular" version of the fix, not the Reloaded one.

Edit 2: Well, now I'm confused. I quit the game while writing this issue because in 0.8.2 there's no pause on focus loss, and my keystrokes were being sent to the game. Once I reopened the game, shadows were low-res. I tried swapping back and forth between 0.8.2 and 0.8.3, testing different values, but shadows are low-res. I've attached the log file, apparently the memory pattern scan fails for the camera shake but works for the shadow resolution part. I've also attached my config and the hashes of the fix's .asi , to prove I'm not going crazy

MetaphorFix.log MetaphorFix.ini.txt explorer_P7c1orZQxz ApplicationFrameHost_ULvMb7r4Ib

Edit 3: Tested 0.7.9, 0.8.0 and increased shadow res works. Tested 0.8.1, 0.8.2, shadows are low-res. I could've sworn I was using 0.8.2 and that was working, I don't know what to say.

system2ckc commented 1 week ago

The shadows tweak atleast on Steam version does work. As for the camera, for me I had to enable it in-game, and then set to true in the metaphor ini. If the in-game is set to disable, the metaphor tweak isn't working as intended.

Lyall commented 1 week ago

So to clarify, you're still having issues with the shadow resolution when using v0.8.3 of MetaphorFix with your MS Store version of the game?

Also, the camera shake option does not work for you and the pattern scan for that fails?

ipisano commented 1 week ago

So to clarify, you're still having issues with the shadow resolution when using v0.8.3 of MetaphorFix with your MS Store version of the game?

Also, the camera shake option does not work for you and the pattern scan for that fails?

As you can see from the attached MetaphorFix.log at line 3 I'm running 0.8.3, scroll down to line 129 and you can see the pattern scan fails. And yes, I re-re-re-re-tested and confirm that shadows are broken, actually I tested with no mod at all and shadows are slightly higher resolution. The breaking point for the increased shadow resolution working with me is 0.8.1, as in the last version they work properly on is 0.8.0

At the moment I'm using 0.8.0 and I'm kind of happy with it, asides from the camera sway disabler not working but I just disabled it in the game's settings instead (I guess it disables more kind of camera movements? I don't know honestly as I've never seen your implementation).

I understand you probably don't have access to this version of the game, if I can do anything to help you get to the bottom of this let me know, asides from lending you my MS Account for security concerns.

Lyall commented 4 days ago

So to clarify, you're still having issues with the shadow resolution when using v0.8.3 of MetaphorFix with your MS Store version of the game? Also, the camera shake option does not work for you and the pattern scan for that fails?

As you can see from the attached MetaphorFix.log at line 3 I'm running 0.8.3, scroll down to line 129 and you can see the pattern scan fails. And yes, I re-re-re-re-tested and confirm that shadows are broken, actually I tested with no mod at all and shadows are slightly higher resolution. The breaking point for the increased shadow resolution working with me is 0.8.1, as in the last version they work properly on is 0.8.0

At the moment I'm using 0.8.0 and I'm kind of happy with it, asides from the camera sway disabler not working but I just disabled it in the game's settings instead (I guess it disables more kind of camera movements? I don't know honestly as I've never seen your implementation).

I understand you probably don't have access to this version of the game, if I can do anything to help you get to the bottom of this let me know, asides from lending you my MS Account for security concerns.

I'm curious as to why the shadow resolution wouldn't be working for you as it appears to be detected and modifying the correct area of code (though I need to clarify that with access to the game exe). Are you using SpecialK with this game?

You don't need to share account details or anything. Just uploading the game exe will let me compare patterns and such which should be enough. Obviously I can't test the changes on an exe but I could generate a test build and then you could test it and report back.

So to dump the exe for the MS Store version, you'll need to use UWPDumper. You just launch the game, then launch the x64 version of UWPInjector.exe, type the process ID and it'll spit out unencrypted dumped game files. You would then upload the METAPHOR.exe executable to somewhere like Pixeldrain or whatever file host you prefer.

ipisano commented 3 days ago

There you go, sorry for the rar, actually had to go and download it myself because 7zip kept getting to 99% instantly and then being stuck there for minutes. The password is "shadowsplz" without quotation marks. Let me know if you need anything else.

Oh and since you asked I don't use SpecialK, I do use the latest ReShade with addons support. I didn't mention it as I've already tested with it disabled (.dll renamed) and excluded it being the culprit.