search

LycheeOrg / Lychee-Docker

Docker image for Lychee
https://lycheeorg.github.io/
165 stars 56 forks source link

Add devtools image to cron build #159

Closed d7415 closed 1 year ago

d7415 commented 1 year ago

It's not pretty, but it's an image with the development dependencies installed.

ildyria commented 1 year ago

COMPOSER_NO_DEV=0 I am not fan of double negatives... I know that composer is in dev mode by default, but I don't think this should dictate the variable naming in our case.

I would rather see COMPOSER_DEV = 0 / 1 as it makes it clear that we are in dev mode or not.

d7415 commented 1 year ago

COMPOSER_NO_DEV=0 I am not fan of double negatives... I know that composer is in dev mode by default, but I don't think this should dictate the variable naming in our case.

I would rather see COMPOSER_DEV = 0 / 1 as it makes it clear that we are in dev mode or not.

I'd agree if it was ours, but it's composer's variable. To change it we'd have to take in whatever and export it as this anyway for composer.

ildyria commented 1 year ago

crap.

ildyria commented 1 year ago

LGTM.