search

LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

Lychee Photo View "Show Map" alert popup #175

Closed bluser86 closed 4 years ago

bluser86 commented 4 years ago

Let me start off with that I really like Lychee for its good looking and to the point UI. So great job to all you contributors for making it happen :)

Detailed description of the problem

When linking to an image using the Lychee Photo View link it first shows an alert popup with the text "Show map" without clicking on anything. The offending line seems to be this one:

https://github.com/LycheeOrg/Lychee-front/blob/6fb5d5ef815cc76a6c0a60dc08dc126ca8a4453e/scripts/view/main.js#L210

Steps to reproduce the issue

Copy a Lychee Photo View share link and open it in your browser.

Output of the diagnostics (Settings => Diagnostics)

Diagnostics
    -----------
    Warning: Dropbox import not working. dropbox_key is empty.

    System Information
    ------------------
    Lychee-front Version:      3.2.16
    Lychee Version (git):      499a4ba (master) - Data not in Cache
    DB Version:                040000
    System:                    Linux
    PHP Version:               7.4
    MySQL Version:             10.4.11-MariaDB

    Lychee total space:        193.58 MB
    Upload folder space:       130.91 MB
    System total space:        290.09 GB
    System free space:         42.58 GB (14%)

    Imagick:                   1
    Imagick Active:            1
    Imagick Version:           1801
    GD Version:                2.2.5

    Config Information
    ------------------
    version:                   040000
    check_for_updates:         0
    sorting_Photos_col:        title
    sorting_Photos_order:      ASC
    sorting_Albums_col:        max_takestamp
    sorting_Albums_order:      ASC
    imagick:                   1
    skip_duplicates:           0
    small_max_width:           0
    small_max_height:          360
    medium_max_width:          1920
    medium_max_height:         1080
    lang:                      en
    layout:                    0
    image_overlay:             1
    image_overlay_type:        desc
    default_license:           reserved
    compression_quality:       90
    full_photo:                1
    delete_imported:           0
    Mod_Frame:                 1
    Mod_Frame_refresh:         30
    thumb_2x:                  1
    small_2x:                  1
    medium_2x:                 1
    landing_page_enable:       0
    landing_owner:             
    landing_title:             
    landing_subtitle:          
    landing_facebook:          
    landing_flickr:            
    landing_twitter:           
    landing_instagram:         
    landing_youtube:           
    landing_background:        dist/cat.jpg
    site_title:                Krypt IMG
    site_copyright_enable:     0
    site_copyright_begin:      2019
    site_copyright_end:        2019
    additional_footer_text:    
    display_social_in_gallery: 0
    public_search:             0
    public_recent:             0
    recent_age:                1
    public_starred:            0
    downloadable:              0
    photos_wraparound:         1
    map_display:               0
    zip64:                     1
    map_display_public:        0
    map_provider:              Wikimedia
    force_32bit_ids:           0
    map_include_subalbums:     0
    update_check_every_days:   3
    has_exiftool:              0
    share_button_visible:      0
    has_ffmpeg:                1

Browser and system

Chromium Version 79.0.3945.117 (Official Build) Arch Linux (64-bit) Firefox Version 72.0.1 Arch Linux (64-bit) Vivaldi on Windows 7

tmp-hallenser commented 4 years ago

Please give #176 a try (don't forget npm run compile to update files after pulling)

bluser86 commented 4 years ago

Works great, thanks!