search

LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

suggestion: remove google fonts dependency #208

Closed rnwgnr closed 2 years ago

rnwgnr commented 4 years ago

Detailed description of the problem

There are imports of google fonts currently in page.css and landing.css. I'd like to suggest to remove this dependency either by shipping the required fonts with the package or just avoid the usage of another font. Self-hosting a personal image gallery and make it depend on other services seems pointless for me.

As far as i can tell the page looks fine even without the additional font.

tmp-hallenser commented 4 years ago

I think we don't use the fonts. Can someone confirm this? In the main.css delivered to the browser, I don't see any reference to roboto font.

rnwgnr commented 4 years ago

I've grep'ed through the files shipping with 4.0.6:

grep -r * -e "Roboto"
public/installer/assets/css/style.css:@import url("https://fonts.googleapis.com/css?family=Roboto:400,300,500,700,900");
public/installer/assets/css/style.css:  font-family: Roboto, Helvetica Neue, Helvetica, Arial, sans-serif;
public/installer/assets/css/style.css:  font-family: Roboto, Helvetica Neue, Helvetica, Arial, sans-serif;
public/installer/assets/css/style.css:  font-family: Roboto, Helvetica Neue, Helvetica, Arial, sans-serif;
public/installer/assets/css/style.css:  font-family: Roboto, Helvetica Neue, Helvetica, Arial, sans-serif;
public/installer/assets/css/style.css:  font-family: Roboto, Helvetica Neue, Helvetica, Arial, sans-serif;
public/installer/assets/css/style.css:  font-family: Roboto, Helvetica Neue, Helvetica, Arial, sans-serif;
public/installer/assets/css/style.css:  font-family: Roboto, Helvetica Neue, Helvetica, Arial, sans-serif;
public/dist/page.css:@import url("https://fonts.googleapis.com/css?family=Roboto:300,400,700,900");
public/dist/page.css:  font-family: 'Roboto', sans-serif;
public/dist/page.css:      font-family: 'Roboto', sans-serif;
public/dist/page.css:  font-family: 'Roboto', sans-serif;
public/dist/landing.css:@import url("https://fonts.googleapis.com/css?family=Roboto:300,400,700,900");
public/dist/landing.css:  font-family: 'Roboto', sans-serif;
public/dist/landing.css:      font-family: 'Roboto', sans-serif;
vendor/laravel/framework/src/Illuminate/Mail/resources/views/html/themes/default.css:    font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif,
vendor/symfony/error-handler/Resources/assets/css/error.css:body { background-color: #fff; color: #222; font: 16px/1.5 -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif; margin: 0; }