LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

Add Sensitive folders. #233

Closed ildyria closed 3 years ago

ildyria commented 3 years ago

related https://github.com/LycheeOrg/Lychee/pull/822

kamil4 commented 3 years ago

OK, so I tested this feature and there are a couple of things that bother me:

ildyria commented 3 years ago
  • Why is there this redundant Sensitive button at the very top of the album visibility dialog? I don't think it belongs in there (and certainly not so prominently; it should be at the bottom and probably should be a simple checkbox). Given that you added a nice, prominent button in the header, do we need it in the dialog box at all?
  1. Because people might miss the triangle.

  2. Just the triangle is not enough to give a proper explanation of what is going on. Especially with regard to the visible/hidden behavior.

  3. The eye indicates the difference between:

    • not public (white)
    • public visible (green)
    • public hidden (orange)

    I was unsure how to integrate the cases:

    • not public & sensitive
    • public & sensitive
    • public hidden & sensitive

    This lead to the addition of the warning sign.

  4. As the setting impact the visibility of the album depending of the default values set, I thought it would be a good idea to group it in the visibility pannel.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication