Closed ildyria closed 3 years ago
OK, so I tested this feature and there are a couple of things that bother me:
albums.refresh()
to ensure a consistent view (like we do in album.setPublic
).
- Why is there this redundant Sensitive button at the very top of the album visibility dialog? I don't think it belongs in there (and certainly not so prominently; it should be at the bottom and probably should be a simple checkbox). Given that you added a nice, prominent button in the header, do we need it in the dialog box at all?
Because people might miss the triangle.
Just the triangle is not enough to give a proper explanation of what is going on. Especially with regard to the visible/hidden behavior.
The eye indicates the difference between:
I was unsure how to integrate the cases:
This lead to the addition of the warning sign.
As the setting impact the visibility of the album depending of the default values set, I thought it would be a good idea to group it in the visibility pannel.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells
No Coverage information
0.0% Duplication
related https://github.com/LycheeOrg/Lychee/pull/822