Custom album covers

[evoludolab]

Draft pull request to implement setting custom cover images for albums, see LycheeOrg/Lychee#442

This pull request implements the front end for setting custom album covers by extends the context menu for photos and albums with Set/Remove Album cover to set/remove custom album covers of the parent album. The corresponding changes in the back end are in a separate pull request LycheeOrg/Lychee#875

IMPORTANT:

• ⚠️ this draft uses album.description to store the information of custom covers. It requires a new column cover in the album table, which is beyond my pay grade.
• SQL query in AlbumController.php should be reviewed (this is completely unfamiliar territory...)
• something seems amiss with the gulpfile because iconic.svg does not get processed (the new icon needs to be manually added to resources/views/includes/svg.blade.php and resources/views/view.blade.php)
• only English localization done
• support for 3 distinct images for albums dropped (seems overkill given that 2 are barely visible); if this is acceptable some code cleaning and streamlining would be recommended

[kamil4]

OK, I added the missing pieces for selecting a subalbum as cover; can you guys test?

Smart albums now display "public" badge for if the Starred or Recent albums are public. I'm undecided if I like that or not... It's probably an improvement, although I may tweak the ordering...

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

[ildyria]

I'm unsure about having the cover badge showing up for albums. For pictures it is pretty obvious but for album I feel this is overkill. :thinking:

[kamil4]

I'm unsure about having the cover badge showing up for albums. For pictures it is pretty obvious but for album I feel this is overkill. thinking

I don't get it. To me they seem like exactly the same case? A user can select for a cover of an album either a photo from the album as or a cover from a subalbum. In either case we give the same visual indication. Why should one be obvious and the other an overkill?

[ildyria]

I will check. :)

[evoludolab]

In my original attempt only the context menu entry and the colour of its accompanying icon changed for a currently selected photo/sub album. This was subtle to the point of obscurity... I am with @kamil4 and already got totally used to the badges. My initial concerns with them completely evaporated after @ildyria pointed out that badges are only visible for the owner of the album.