search

LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

frontend code for disabling direction display on embedded map #243

Closed sjml closed 3 years ago

sjml commented 3 years ago

This is the frontend code addressing LycheeOrg/Lychee#886, reading the configuration object and not displaying the directional cone if the setting is off.

sjml commented 3 years ago

This is fine but you are missing changes in https://github.com/LycheeOrg/Lychee-front/blob/master/scripts/main/lychee.js

Currently lychee.map_display_direction is not set.

Ah, thanks. I had thought that object was auto-populated from the database.

ildyria commented 3 years ago

You may want to add something near line 200 and line 270 in the script/lychee.js

sjml commented 3 years ago

You may want to add something near line 200 and line 270 in the script/lychee.js

Will do. I'll set it to default to true. (Although.... it seems like everything else defaults to false. Is that a style choice or reflective of how each of those settings actually should default?) I misread how that code was working. :)

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sjml commented 3 years ago

This should all be set correctly now. @ildyria, look good to you?

sjml commented 3 years ago

Looking some more -- what about hiding the "Direction" data in the sidebar? I can do a push that accomplishes that, too, but could see it being a conceptually different thing (raw EXIF data vs. map visualization).

ildyria commented 3 years ago

Looking some more -- what about hiding the "Direction" data in the sidebar? I can do a push that accomplishes that, too, but could see it being a conceptually different thing (raw EXIF data vs. map visualization).

I don't have a strong opinion on that to be honest. My camera needs to be connected to my phone if I want to have GPS coordinates. Map visualization is very nice, but the use in practice makes it useless for me. I do see its use with phones but as a photographer, why would I take pictures with my phone when I can have better results with my full-frame camera.

Then again in the case of phones, we need to trust the integrated compass which from experience is often off...

Conclusion, I don't care, maybe the other will have a stronger opinion.

By the way, feel free to drop on our gitter: https://gitter.im/LycheeOrg/Lobby you can easily login with your github ID. :)