search

LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

Refactor timestamps anew #265

Closed nagmat84 closed 3 years ago

nagmat84 commented 3 years ago

This PR is a new attempt for the unfortunate, previous PR #262.

Changes since the previous PR:

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.5% 3.5% Duplication

nagmat84 commented 3 years ago

One thing to point out is that the timezone is now always printed, resulting in a busier output. In particular, in the info sidebar, at least for me (I guess it's locale-dependent?) the timestamps now occupy two rows. I'm OK with that but I wonder if that changed will be universally loved...

It is not only locale-dependent but also depends on the resolution of the screen or more precisely the window size of your browser. If I use Firefox with a maximized window at 1920x1200px, then the timestamps tightly fit into a single line in the sidebar. If I decrease the window size just a small amount (about 10px), then the timestamps wrap into two lines. However, this also happens with other values if I reduce the window size even further.