LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

Fix location type #286

Closed nagmat84 closed 2 years ago

nagmat84 commented 2 years ago

The attributes latitude and longitude are nullable JS numbers. The latitude and longitude 0°0'0''.0000 are valid coordinates, but falsy in JS. So we must not use shortcut notations like if (latitude) to check if we have a latitude/longitude, but explicitly check for !== null .

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication