Closed qwerty287 closed 2 years ago
I also updated the Node.js version of Github Actions, Node 15.x is end of life and this should better test the integrations.
Makes sense to me!
Please don't merge yet, there an issue with CSS compilation and some rules (take a look at CI logs). I'll fix them soon.
Please don't merge yet, there an issue with CSS compilation and some rules (take a look at CI logs). I'll fix them soon.
This should be fixed now.
I have merged consistent_json_api
into master
and rebased your branch querty287/sass
as sass_rebased
onto the new master. To update your PR, I believe the following commands should be the the right ones.
Attention:
origin
points to your own repository git@github.com:qwerty287/Lychee-front.git
.Commands:
git checkout master # Checkout the current master of Lychee-front, the only important thing is that your are not on the branch `sass`
git remote add lychee-org git@github.com:LycheeOrg/Lychee-front.git # Add the LycheeOrg-Repo as a remote unless you haven't yet
git branch -D sass # Delete your local branch `sass`
git checkout -b sass --track lychee-org/sass_rebased # Checkout a new local branch `sass` from `sass_rebased`
git pull # Pull it
git branch -u origin/sass # Change to upstream to your repository, this assumes `origin` points to `qwerty287`
git push # Try to push it, this is expected to fail, but make sure that GIT tries to push to the correct remote
git push --force # Now push forcefully
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
node-sass
is deprecated, the new sass library is recommended. This updates tosass
and also fixes the issues I had withnode-sass
on node 17.