LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

Move from `node-sass` to `sass` #292

Closed qwerty287 closed 2 years ago

qwerty287 commented 2 years ago

node-sass is deprecated, the new sass library is recommended. This updates to sass and also fixes the issues I had with node-sass on node 17.

qwerty287 commented 2 years ago

I also updated the Node.js version of Github Actions, Node 15.x is end of life and this should better test the integrations.

d7415 commented 2 years ago

Makes sense to me!

qwerty287 commented 2 years ago

Please don't merge yet, there an issue with CSS compilation and some rules (take a look at CI logs). I'll fix them soon.

qwerty287 commented 2 years ago

Please don't merge yet, there an issue with CSS compilation and some rules (take a look at CI logs). I'll fix them soon.

This should be fixed now.

nagmat84 commented 2 years ago

I have merged consistent_json_api into master and rebased your branch querty287/sass as sass_rebased onto the new master. To update your PR, I believe the following commands should be the the right ones.

Attention:

Commands:

git checkout master                                                  # Checkout the current master of Lychee-front, the only important thing is that your are not on the branch `sass`
git remote add lychee-org git@github.com:LycheeOrg/Lychee-front.git  # Add the LycheeOrg-Repo as a remote unless you haven't yet
git branch -D sass                                                   # Delete your local branch `sass`
git checkout -b sass --track lychee-org/sass_rebased                 # Checkout a new local branch `sass` from `sass_rebased`
git pull                                                             # Pull it
git branch -u origin/sass                                            # Change to upstream to your repository, this assumes `origin` points to `qwerty287`
git push                                                             # Try to push it, this is expected to fail, but make sure that GIT tries to push to the correct remote
git push --force                                                     # Now push forcefully
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication